Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests-integration::TemplateProvider cleanup #1368

Open
2 tasks
jbesraa opened this issue Jan 21, 2025 · 1 comment · May be fixed by #1369
Open
2 tasks

tests-integration::TemplateProvider cleanup #1368

jbesraa opened this issue Jan 21, 2025 · 1 comment · May be fixed by #1369
Labels
integration-tests refactor Implies refactoring code

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Jan 21, 2025 •
edited
Loading

  • Move download_bitcoind_tarball, unpack_tarball and read_tarball_from_file outside of template_provider.rs file
    - [ ] Consider moving to async API, specificly download_bitcoind_tarball(this is also a wrong name, this function performs http get request only)

  • Document public functions
@jbesraa
Copy link
Contributor Author

jbesraa commented Jan 21, 2025

not sure about (2), maybe that's a bad idea

@jbesraa jbesraa linked a pull request Jan 21, 2025 that will close this issue
Draft
@plebhash plebhash added integration-tests refactor Implies refactoring code labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration-tests refactor Implies refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TemplateProvider cleanup jbesraa/stratum
2 participants
@jbesraa @plebhash