Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu doesn't work in Chrome #158

Open
twlz0ne opened this issue Feb 23, 2019 · 8 comments
Open

Context menu doesn't work in Chrome #158

twlz0ne opened this issue Feb 23, 2019 · 8 comments

Comments

@twlz0ne
Copy link

twlz0ne commented Feb 23, 2019

There is nothing happened when I click the context menu item Edit with Emacs in Chrome.
After debugging the source code, I found that the tab_port.sender is read-only:

edit-wit-emacs-context-menu-doesnt-work-in-chrome


  • macOS 10.11.6
  • Google Chrome 72.0.3626.109 (Official Build) (64-bit)
  • Edit with Emacs 1.15
@stsquad
Copy link
Owner

stsquad commented Feb 25, 2019

I wonder if Google have changed the tab port API?

@stsquad
Copy link
Owner

stsquad commented Feb 25, 2019

Well I can re-create the problem on Linux with Chrome 72 so I suspect this is a change to the API. Looks like this was last touched in bug #85 but I'll have to do some digging. If you feel upto it you are welcome to have a look yourself.

@twlz0ne
Copy link
Author

twlz0ne commented Feb 26, 2019

I think Google made this change just to prevent sender from being modified. So, there is no reason to use it anymore.

@stsquad
Copy link
Owner

stsquad commented Mar 16, 2019

OK this is weird - it works on my desktop machine...

@stsquad
Copy link
Owner

stsquad commented Mar 16, 2019

sigh

Works with Chromium Version 72.0.3626.121 (Developer Build) (64-bit)
Fails with Google Chrome Version 73.0.3683.67 (Official Build) beta (64-bit)

@stsquad
Copy link
Owner

stsquad commented Mar 16, 2019

@twlz0ne ok I think I've removed the need for tab_port.sender. Can you test the latest master and I'll make a release.

@twlz0ne
Copy link
Author

twlz0ne commented Mar 16, 2019

Msg id undefined when I return to the browser after finishing editing:

emacs-chrome-msg-id-undefined

Then there is nothing appears in the textarea.

@stsquad
Copy link
Owner

stsquad commented Mar 16, 2019

Hmm I'm confused as to what is going wrong then.... and chance you could enable the logging messages and capture them for the whole edit sequence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants