Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kysely-bun-worker should export the BunWorkerDialectConfig type #12

Open
tiagobnobrega opened this issue Nov 23, 2024 · 1 comment
Open

Comments

@tiagobnobrega
Copy link

The kysely-bun-worker should export the BunWorkerDialectConfig type. This makes it easier for TS app devs to isolate dialect config in separate variables:

const dialectConfig:BunWorkerDialectConfig = {url:"..."};

Also on the README file, the example is wrong. It's creating a new SqliteWorkerDialect instead of a new BunWorkerDialect.

@subframe7536
Copy link
Owner

subframe7536 commented Nov 23, 2024

Thanks for your suggestion! This should be fixed in next release.

You can use Exclude<BunWorkerDialect['config'], undefined> right now

subframe7536 added a commit that referenced this issue Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants