Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback for "Hyperscore" example project is broken #3940

Open
4 tasks done
pikurasa opened this issue Jul 12, 2024 · 11 comments
Open
4 tasks done

Playback for "Hyperscore" example project is broken #3940

pikurasa opened this issue Jul 12, 2024 · 11 comments

Comments

@pikurasa
Copy link
Collaborator

Description

Expected Behavior

Our "Hyperscore" super-example can be found here: https://sugarlabs.github.io/musicblocks/index.html?id=1523896294964170&run=True&run=True

It paints the music just fine, but when you press the play button to generate a stack of notes for what you played, it creates rests, throws a few errors, and even seems to get a start block stuck inside a note. (See images below.)

Screenshots

Screenshot from 2024-07-11 21-09-44
2.
Screenshot from 2024-07-11 21-10-11
3.
Screenshot from 2024-07-11 21-10-30
4.
Screenshot from 2024-07-11 21-10-38

How to Reproduce

Open https://sugarlabs.github.io/musicblocks/index.html?id=1523896294964170&run=True&run=True, paint a bit, and press the play button at the top.

Note blocks will generate, but some will generate incorrectly.

Console log Errors:

Here are all the logs from the session:

sugarlabs.github.io-1720747474605.log

Environment:

Presumably All

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@dubeanant
Copy link
Contributor

Hello @pikurasa ,

I’ve decided to take on this issue. Could you provide any insights on why this error is occurring or how I might resolve it?

@akshayw1
Copy link

@dubeanant , Are you working on the issue?

@dubeanant
Copy link
Contributor

@dubeanant , Are you working on the issue?

Nope, go ahead

@akshayw1
Copy link

akshayw1 commented Nov 8, 2024

Is anyone working on this @pikurasa Can you assign me this

@pikurasa
Copy link
Collaborator Author

pikurasa commented Nov 8, 2024

Is anyone working on this @pikurasa Can you assign me this

Go for it!

@suryaanshah
Copy link
Contributor

Hi @pikurasa
I am having some issues reproducing this issue.

The URL you provide doesn't seem to give an issue. Is there something I am not saying. Would really appreciate anybody's assistance on this one.

hypersocreissue.mp4

@pikurasa
Copy link
Collaborator Author

The URL you provide doesn't seem to give an issue. Is there something I am not saying. Would really appreciate anybody's assistance on this one.

The Planet server is down at the moment.

In the meantime, I'm trying to see if we can get you a file you can open while we're working that out.

@walterbender
Copy link
Member

Sorry. I should have added this project to the examples folder, but I never did. I don't have a local copy.

@pikurasa
Copy link
Collaborator Author

Sorry. I should have added this project to the examples folder, but I never did. I don't have a local copy.

I looked even deeper onto some backups I have of old files, and I found this (from 4/16/2018):

Remix of Hyperscore tonal.zip

It appears to be a remix of one of your versions, @walterbender

I'll make a PR. The file does seem to work...

@pikurasa
Copy link
Collaborator Author

Before making a PR, I'm trying to clean it up. This is it's current state. The logic could be clearer, but it works ok right now.

HyperScore-Tonal2.zip

@pikurasa
Copy link
Collaborator Author

Before making a PR, I'm trying to clean it up. This is it's current state. The logic could be clearer, but it works ok right now.

HyperScore-Tonal2.zip

@suryaanshah if you like, you're welcome to start from the file pasted above and improve it.

You should reference https://github.com/sugarlabs/musicblocks/tree/master/guide/#37-interactions as a guide as you work to get it working. If you like, you could start from the file above and rearrange the blocks to be as they are in the image. Then, you can see if you can reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants