-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the closing of all the piemenus #4050
Comments
I m working on this issue and recreating the hide event and make them work accordingly desired. |
@omsuneri i was looking at this issue and trying to recreate it looks like the current behavior is only on the context menu and not the grid menu |
@justin212407 nice to hear this but I think this might not be needed anymore as I had talked with Walter and also I m working on this so it will be better if you try to tackle some another issue |
This issue has been addressed in pull request #4224 |
Current Behavior
Currently we have to click on the cancle button in order to close the piemenu we open like the context menu, grid menu and all
so this might somewhat be optimized.
Desired Behavior
the main task is to allow all the piemenus to close whenever you click somewhere in the canvas along.
also the thing we need to think of is to make the code more optimistic.
Screenshots / Mockups
along with these two piemenus we have to make all of them to work accordingly.
Implementation
just to simply recreate the cancle function of the piemenus in an optimistic manner.
Acceptance Tests
N/a
Environment
Additional Information
Checklist
Thank you for contributing to our project! We appreciate your help in improving it.
📚 See contributing instructions.
🙋🏾🙋🏼 Questions: Community Matrix Server.
The text was updated successfully, but these errors were encountered: