Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird behaviour of MB projects when using download and recording option #4239

Open
4 tasks
falgun143 opened this issue Jan 7, 2025 · 6 comments · May be fixed by #4245
Open
4 tasks

Weird behaviour of MB projects when using download and recording option #4239

falgun143 opened this issue Jan 7, 2025 · 6 comments · May be fixed by #4245
Labels
Issue-Bug

Comments

@falgun143
Copy link
Contributor

falgun143 commented Jan 7, 2025 •
edited
Loading

Description

  1. When a MB project is running and when download button or the record button is clicked it is causing buggy music.
  2. When Stop sharing is already clicked by the user then text message of click on stop sharing is shown.
  3. When we click on cancel button when recording is done, It still downloads the file.

Expected Behavior

  1. When a MB project is running the download button and the record button should be disabled.
  2. When Stop sharing is already clicked by the user then text message of click on stop sharing should not be shown.
  3. When we click on cancel button when recording is done, It still downloads the file. Which should not happen.

Videos

https://github.com/user-attachments/assets/b4a29903-32d8-450f-81a3-51b2a9c070be
2.

Recording.2025-01-07.155838.mp4

How to Reproduce

Follow above videos.

Console log Errors:

Environment:

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.
@falgun143
Copy link
Contributor Author

@walterbender and @pikurasa any thoughts?

@pikurasa
Copy link
Collaborator

pikurasa commented Jan 7, 2025

I think it makes sense to disable record and download initiation when a project is running.

As for the other parts of this issue, I'm not sure if I follow. Perhaps we should discuss each aspect separately.

@BeNikk BeNikk mentioned this issue Jan 7, 2025
Closed
@falgun143
Copy link
Contributor Author

@walterbender should i create a single pr for all 3 points ?or should I create new issues. As 2nd and 3rd ones are small changes.

@pikurasa
Copy link
Collaborator

pikurasa commented Jan 7, 2025

@falgun143 Please solve separate issues in separate PRs, even if there are related

Bundling them can make them hard to review, which can prolong the time until we can merge

@falgun143
Copy link
Contributor Author

@BeNikk The buttons should remain disabled throughout the music playback, but they currently stay active after 2 seconds, which is incorrect. Additionally, there is a color mismatch between the "Record" and "Save" buttons.

@falgun143 falgun143 linked a pull request Jan 8, 2025 that will close this issue
Open
@BeNikk
Copy link
Contributor

BeNikk commented Jan 8, 2025

Yes, it seems lke the issue, I will have to investigate a bit

@Commanderk3 Commanderk3 mentioned this issue Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disabled record and save buttons while music is playing falgun143/musicblocks
3 participants
@pikurasa @falgun143 @BeNikk