Replace deprecated darken with color.adjust for Sass compliance #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quozl
requested changes
Jan 9, 2025
There was a problem hiding this comment.
- don't write so much in the pull request alone, what you said should be in the commit message,
- rewrite your commit message and force push, see our guidance for a checklist,
- add the problem to the commit message, as the GitHub issue will be lost and the commit message kept,
- add the solution to the commit message, as the GitHub pull request will be lost and the commit message kept,
- do not make changes unrelated to your stated intent, be more careful, use interactive add of git if necessary to avoid any changes made by your software tools,
Please fix these things in your existing branch, squash your commits, and then force push to update the pull request.
There was a problem hiding this comment.
Generated files should not be committed.
There was a problem hiding this comment.
Generated files should not be committed.
|
|
||
| .ion-sticky { | ||
| top: 50%; | ||
| transform: translateY(-50%); | ||
| -webkit-transform: translateY(-50%); |
| @@ -72,10 +65,6 @@ $medium-background-hover: darken($medium-background, $darken-percent); | |||
| display: block; | |||
| clear: both; | |||
| transition: padding 0.1s ease-out; | |||
| -webkit-transition: padding 0.1s ease-out; | |||
| @@ -106,7 +95,7 @@ $medium-background-hover: darken($medium-background, $darken-percent); | |||
| background: $github-background; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Unnecessary change to whitespace.
| &instagram { | ||
| // Instagram uses background color |
There was a problem hiding this comment.
Unexpected removal of comment.
| @@ -288,8 +276,8 @@ $medium-background-hover: darken($medium-background, $darken-percent); | |||
| &medium { | |||
| color: $medium-color; | |||
| font-size: 3rem; | |||
| height: 3rem; | |||
| width: 3rem; | |||
| height: 3rem; | |||
| @@ -299,4 +287,4 @@ $medium-background-hover: darken($medium-background, $darken-percent); | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Removal of newline at end of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
darkenbeing used, causing warning #633 the warning of depreciated darken function in the terminal andChanges/explanation
sass /css/ion_icon_customization.scss /css/ion_icon_customization.cssto generate the compiled css file, which was necessary for "@use keyword" in @use "sass:color" which was used to use color thing to replaced darken the main thing.Testing