Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate duplicated logic for extracting ORCIDs #15

Open
peetucket opened this issue Oct 3, 2023 · 1 comment
Open

Consolidate duplicated logic for extracting ORCIDs #15

peetucket opened this issue Oct 3, 2023 · 1 comment

Comments

@peetucket
Copy link
Contributor

We have code that contains logic for extracting ORCIDs from cocina in both dor_indexing_app and in the orcid_client gem. This code is largely duplicative and is sometimes changed in one location, but not the other, which can lead to unexpected bugs. There is also other code in dor_indexing_app that deals with extracting data out of cocina that could be of use to other applications.

See for example:

Consider:

  • moving this logic in the cocina-models gem where it can be easily shared and not duplicated
  • creating a new gem, e.g. cocina-support, that would hold this logic and can be easily updated without requiring a full update of all apps (which is needed to keep cocina-models in sync)
@ndushay
Copy link
Contributor

ndushay commented Jan 30, 2024

moving this to dor_indexing gem, as it is no longer relevant in dor_indexing_app

@ndushay ndushay transferred this issue from sul-dlss-deprecated/dor_indexing_app Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants