Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPER-TOKEN] Make compatible with current ethereum-contracts release #29

Open
6 tasks
philipandersson opened this issue Sep 14, 2023 · 0 comments
Open
6 tasks
Assignees
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Spike Task that is to be timeboxed

Comments

@philipandersson
Copy link

philipandersson commented Sep 14, 2023

  • Make compatible with current ethereum-contracts release
  • Make sure new releases of ethereum-contracts validates examples to make sure we update examples as needed.
  • Revamp of the project structure:
  • multi-projects repo: e.g. hardhat-example/ hardhat full examples, and foundry-example/ minimum foundry example.
  • migrate from truffle to hardhat for the main project.
  • Make the pattern of defining ICustomSuperToken (See ISETHCustom as an example) explicit in all pure super token examples.
    • Some base functionalities are exposed through SuperToken self-functions, such as selfMint, selfBurn, selfTransfer, etc.
    • For the off-chain code, the CustomSuperTokenProxy address should be casted to the corresponding ICustomSuperToken interface to be useful.
  • Adding an example of how to override existing SuperToken functions (e.g. GoodDollar overrides transfer)
  • Adding an example where custom super token exempts from managed super token logic upgrade process:
    • This a necessary step before opt-in for an entire different deployment of custom super token logic.
    • Should this be even part of a new SuperToken factory option?
  • Stretch goal: minimum CI.
@philipandersson philipandersson added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Sep 14, 2023
@philipandersson philipandersson added the Type: Spike Task that is to be timeboxed label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps Type: Spike Task that is to be timeboxed
Projects
None yet
Development

No branches or pull requests

2 participants