Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-package doesn't include source maps #7792

Open
DetachHead opened this issue Nov 24, 2022 · 1 comment
Open

svelte-package doesn't include source maps #7792

DetachHead opened this issue Nov 24, 2022 · 1 comment
Labels
feature / enhancement New feature or request pkg:svelte-package Issues related to svelte-package
Milestone

Comments

@DetachHead
Copy link

Describe the bug

when running svelte-package, it does not include source maps even when they are enabled in svelte.config.js

Reproduction

// svelte.config.js
import preprocess from 'svelte-preprocess';

const config = {
  compilerOptions: {
    enableSourcemap: true,
  },
  preprocess: preprocess({
    sourceMap: true,
  }),
};

export default config;

Logs

No response

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11500T @ 1.50GHz
    Memory: 672.74 MB / 15.73 GB
  Binaries:
    Node: 18.10.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.33)
    Internet Explorer: 11.0.19041.1566

Severity

annoyance

Additional Information

the src and the package created by svelte-package:
image

@benmccann benmccann added the pkg:svelte-package Issues related to svelte-package label Nov 24, 2022
@dummdidumm dummdidumm added this to the post-1.0 milestone Nov 24, 2022
wickning1 added a commit to txstate-etc/dosgato-dialog that referenced this issue Nov 28, 2022
@benmccann benmccann added the feature / enhancement New feature or request label Jan 20, 2023
@dummdidumm
Copy link
Member

As pointed out in my comment in #11527 I'm not sure how/if we should move forward with this. Most people don't publish their sources, yet source maps are enabled by default, so you would get broken references all over the place. Furthermore, one big source of preprocessing within Svelte files is gone with Svelte 5, as it now understands TS types natively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request pkg:svelte-package Issues related to svelte-package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants