-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building plugin with swc_core
0.88.* leads to segfault / bus error (0.87.* working)
#8540
Comments
I think this is dupe of #7479 |
The serialized form/memory layout of AST of 0.88.x is different from the old versions. This is duplicate of #5060 |
Excellent, thanks @kdy1 |
While it's understandable the breaking changes in AST will appear, is there an existing/planned way for A |
Refer pinned issue. |
@kireevmp to be fair, plugins are still experimental |
True, @Codex-, and I appreciate all the team's work to get even to this point. Making plugins backward-compatible would be a great feat, but that's not what I'm talking about here Is allowing the plugin to fail gracefully when the AST version mismatches possible? It would go a long way if we could show a meaningful message, like
Even if the compatibility information is provided by the plugin developer, and not the SWC team, I feel this would be a significant boost to the end-user experience |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Describe the bug
I author
swc-plugin-import-meta-env
and have found when bumping theswc_core
crates to0.88.*
the built wasm causes a segfault when used with@swc/jest
This issue was raised which provided this minimal reproduction: https://github.com/HermanBilous/test-swc-jest
The plugin contains this for
swc_core
:When reverting
swc_core
to0.87.*
the plugin works as expected again.Input code
No response
Config
No response
Playground link (or link to the minimal reproduction)
https://github.com/Codex-/swc-plugin-error
SWC Info output
No response
Expected behavior
No bus error or segfault
Actual behavior
After reverting, renovate tried to bump this again which was blocked by the integration tests I added:
https://github.com/Codex-/swc-plugin-import-meta-env/actions/runs/7619428112/job/20752472293?pr=36
With
SWC_LOG=info RUST_BACKTRACE=1
Running multiple times gives different errors
Version
1.3.105
Additional context
No response
The text was updated successfully, but these errors were encountered: