-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bobcat to the list of terminal emulators with image preview support #2204
Conversation
Bobcat -a cross-platform vt- can also run yazi with image previews just fine. It supports both iterm2 & sixel protocols with yazi out-of-the-box.
Thanks for the PR, Bobcat looks amazing, nice work! Does Bobcat have any environment variables (like yazi/yazi-adapter/src/brand.rs Lines 35 to 44 in 3739713
yazi/yazi-adapter/src/brand.rs Lines 52 to 63 in 3739713
yazi/yazi-adapter/src/brand.rs Lines 65 to 73 in 3739713
And for yazi/yazi-adapter/src/brand.rs Lines 79 to 86 in 3739713
|
6c32e4c
to
6a5fa71
Compare
Bobcat is added to the list of recognized terminal emulators. It uses the extended device attributes report command (`CSI q <`) to report its id.
Hi, Thank you for your prompt reply and this great tool. I have updated the brands list to include Bobcat. It uses extended device attributes report to reveal its id. Should be fine now, however in case anything else is missing, please let me know, I'll adjust the files asap. |
I noticed that your commit message mentions Did you mean |
Ah, yes, a typo. :) |
Gotcha. Could you rebase the PR? |
4c5698d
to
5058cf2
Compare
I'm going to close this because it still needs some work and hasn't seen any activity recently. @ismail-yilmaz thanks for the effort! |
Hi, I apologize for the inconvenience. I've been dealing with some health issues, which caused the delay. If it is OK with you, I will make a new and proper pull request tomorrow. |
No worries - sure, go for it! |
Bobcat -a cross-platform vt- can also run yazi with image previews just fine. It supports both iterm2 & sixel protocols with yazi out-of-the-box.