Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TogglePassword] Feature not working with Safari's builtin function 'suggest new password' #2413

Open
palgalik opened this issue Dec 1, 2024 · 3 comments
Labels
Bug Bug Fix Status: Waiting Feedback Needs feedback from the author TogglePassword

Comments

@palgalik
Copy link

palgalik commented Dec 1, 2024

  • I'm using Safari's latest version - Version 18.1.1 (20619.2.8.11.12)
  • I don't have any extension installed

Steps to reproduce:

  1. Open Safari.
  2. Navigate to the Toggle Password Demo Page.
  3. Click on the password input field.
  4. Use Safari to suggest a new password.
  5. After the password is inserted, click the toggle icon. You will notice that the password is not revealed.

Here is a video recording:
https://github.com/user-attachments/assets/85d11495-fb3d-4fe4-beef-9c89e35dc60c

@palgalik palgalik added the Bug Bug Fix label Dec 1, 2024
@Kocal
Copy link
Member

Kocal commented Dec 7, 2024

HI @palgalik, and thanks for the issue and video!

For the moment I didn't investigate at all, but I believe this is something than can not be fixed by JavaScript/Stimulus UX. It's a browser feature, and there is a possibility we can not "interfere" with it.

But! As said I didn't investigate, maybe there is hope :)

I'm going to take advantage of this hackday to take a look.

@Kocal
Copy link
Member

Kocal commented Dec 7, 2024

More investigation, after using a suggested password, it looks like Safari use a special type of element (maybe Shadow element? I'm not sure about the french translation here), which use *****:
Capture d’écran 2024-12-07 à 12 55 13
When you click on Show, you can see this element change (and type="password" -> type="text"` aswell), but it looks like we can't interact with it:
image

@smnandre
Copy link
Member

I believe it's part of the new set of security measures from Safari.... and would clearly not advise we "go against"

@Kocal Kocal added Status: Waiting Feedback Needs feedback from the author and removed Status: Needs Review Needs to be reviewed labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Waiting Feedback Needs feedback from the author TogglePassword
Projects
None yet
Development

No branches or pull requests

4 participants