Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data preprocessing #8

Open
Sibo-tao opened this issue Apr 24, 2018 · 1 comment
Open

Data preprocessing #8

Sibo-tao opened this issue Apr 24, 2018 · 1 comment

Comments

@Sibo-tao
Copy link

Hi,

This code is very clean. But there is a problem, I think. When you do color preprocessing, the test data should not be normalized by their own mean and variance, instead, they should be normalized by the same way as the training data, i.e. minus the means of the training data and then divided by the std. of training data. Hope this comment helps you to form a rigorous set of codes.

@Abdelpakey
Copy link

I liked the code and I noticed what you just said and I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants