You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Type II support for promise then is essential for hooking into existing promises' lifecycles and observing them without a massive amount of complexity.
#21
Open
dead-claudia opened this issue
Jan 31, 2021
· 4 comments
Mithril actively relies on it to observe when a promise chain stops, and removing this may break sites using it. (Some of the adjustments in there are because of an async/await change that spawned a bug report against us with multiple people complaining.)
This one is also isolated enough and simple enough to work around that I see value in it having a one-off exception, and I can't think of any other methods with such concerns.
The text was updated successfully, but these errors were encountered:
Is this actually Type III? It doesn't look to me like it's overriding Symbol.species.
(Actually, it also looks to me like it's explicitly overwriting .then so that it wraps the result itself, rather than relying on the built-in .then to do it. But I'm less sure of that.)
@bakkot It's overriding .then, not @@species. Probably should've specified it's more type II, not type III in hindsight, as that's more accurate. I'll change the title appropriately.
dead-claudia
changed the title
Type III support for promise then is essential for hooking into existing promises' lifecycles and observing them without a massive amount of complexity.
Type II support for promise then is essential for hooking into existing promises' lifecycles and observing them without a massive amount of complexity.
Feb 14, 2021
Mithril actively relies on it to observe when a promise chain stops, and removing this may break sites using it. (Some of the adjustments in there are because of an
async
/await
change that spawned a bug report against us with multiple people complaining.)This one is also isolated enough and simple enough to work around that I see value in it having a one-off exception, and I can't think of any other methods with such concerns.
The text was updated successfully, but these errors were encountered: