Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to attach classes to form elements #1

Open
mwotton opened this issue Jan 12, 2012 · 5 comments
Open

no way to attach classes to form elements #1

mwotton opened this issue Jan 12, 2012 · 5 comments

Comments

@mwotton
Copy link

mwotton commented Jan 12, 2012

I'm trying to create a checkbox group. Unfortunately, the checkbox_group helper in pp/helpers/dynamic_forms/check_box_group_helper.rb doesn't provide a way to add a class to the generated label.

line 73: out << "

  • #{markup}#{item}
  • \n"

    I'm passing a custom block in now, but this doesn't help me much in the general run - I'd have to write different code for each different kind of form. Would it be reasonable to attach a class to all form elements?

    @tcocca
    Copy link
    Owner

    tcocca commented Jan 18, 2012

    This sounds like a good idea. Maybe we should take this even further and add support for formtastic or something like that?

    ~ Tom

    @mwotton
    Copy link
    Author

    mwotton commented Jan 20, 2012

    yes, that'd be good. we ended up doing a lot more of it manually than I'd really have liked, formtastic support would have been excellent.

    @tcocca
    Copy link
    Owner

    tcocca commented Feb 5, 2012

    Hi Mark, any chance you want to take a stab at this feature of adding formtastic support? Or even opening it up to adding more html option support to the fields somehow?

    ~ Tom

    @mwotton
    Copy link
    Author

    mwotton commented Feb 7, 2012

    @tcocca I'd like to, but I'm pretty pressed for time at the moment. will circle back when the current massive pile of work is looking less intimidating.

    @tcocca
    Copy link
    Owner

    tcocca commented Feb 8, 2012

    Sounds like we are both in the exact same predicament. Hopefully that clears up soon. Keep me posted on this, don't want to end up doing double work.

    ~ Tom

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants