-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depends field should be left empty if a package depends on no other #208
Comments
It's not really that simple. The idea behind this automatic depends is that jdeb has been designed for java projects (and is mostly used for java projects). You don't have any dependency on java in a Maven project for example but you still need Java to work if you are building a package for a jar. Currently (since #190) when you don't want any dependency you can explicitly set an empty Depends. |
I am also leaning towards not having a default anymore and adding it to all examples explicitly. ...but I have two concerns: "default-jre | java6-runtime" is no longer a good default (given that we are at java8 now). Which begs the question what the default runtime should be? Just use java8? Changing it to java8 could almost as bad as just switching it to . The question is whether such a thing would be semantically OK for a 1.5 release. Calling a release 2.0 just for that does not feel warranted - and this would change in 2.x anyway. (see #195) |
Since there is a work around to set it explicitly to empty I will close this issue for - but be sure it's kept in mind for 2.x. Thanks for reporting. |
The default version for the java-runtime dependency could probably be derived from the target level used by the compiler plugin. But java6-runtime isn't that bad since this dependency is also satisfied by the Java 8 packages. |
...and for ant? Ah! Didn't know that java6-runtime is satisfied by java8 as well. That does make things a little easier if we want to change the default. |
For Ant we could default to the version of the JDK used to run jdeb. |
Meh. I'd say just leave it for the 1.x branch. |
This isn't absolutely true. Certain dependencies like asm are highly On Fri, May 29, 2015 at 1:31 AM, Torsten Curdt [email protected]
|
The default list of possible dependencies (if reintroduced) should probably include 'java-runtime-headless', and/or 'default-jre' may be changed to 'default-jre-headless' as the thinnest requirement:
|
For now |
Otherwise JDeb does nonsense: tcurdt/jdeb#208
Otherwise JDeb does nonsense: tcurdt/jdeb#208
I think we screwed ourselves into a corner here. I would really love to rid of the default Thoughts? @ebourg ? |
Maybe let's get it into the 1.5 release and be done with it. |
Omit Depends: from control file if not set. Fixes #208
…s set. When the change to no longer include the default depends was made in tcurdt#209 to fix tcurdt#208 it entirely eliminated the ability to set the depends programatically. In fact, the field DebMaker.depends is never read.
* Do include the depends field in the control file if and only if it was set. When the change to no longer include the default depends was made in #209 to fix #208 it entirely eliminated the ability to set the depends programatically. In fact, the field DebMaker.depends is never read. * Add unit test for ensuring depends is in control. Also augment DebMakerTestCase#testDependsIsOmittedWhenEmpty to fail if control is missing entirely.
the upgrade of Jdeb to 1.4 adds a default dependency of "default-jre | java6-runtime"
Not all packages need to depend on other packages. Also the debian control file syntax allows the Depends field to be omitted.
The text was updated successfully, but these errors were encountered: