Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use UTC for timestamp in convertToDebianVersion #238

Closed
dbyron0 opened this issue May 20, 2016 · 0 comments
Closed

use UTC for timestamp in convertToDebianVersion #238

dbyron0 opened this issue May 20, 2016 · 0 comments
Milestone

Comments

@dbyron0
Copy link

dbyron0 commented May 20, 2016

As requested in #195 (comment), here's a separate request to change the the timestamp in convertToDebianVersion to UTC. You're right that there are consequences for people using timestamps from some other timezone when they switch to UTC, at least when that other timezone has a positive offset from UTC.

Consider two snapshots made one right after the other -- the first with the existing code, and the second with UTC.

For negative offsets (i.e. west of Greenwich), or no offset at all, dpkg --compare-versions works as expected: the second snapshot is considered newer than the first.

For positive offsets (i.e. east of Greenwich), the dpkg --compare-versions considers the second snapshot older than the first, so manual removal, or --force, etc. is required to get the second snapshot to install.

Another way of thinking about this: if the first UTC snapshot is at least as long after the last pre-UTC snapshot as the UTC offset (e.g. >= 2 hours between snapshots in UTC+2), there's no problem.

@dbyron0 dbyron0 mentioned this issue May 20, 2016
@tcurdt tcurdt added this to the 1.6 milestone May 22, 2016
@tcurdt tcurdt closed this as completed in 6e1b054 Apr 18, 2017
tcurdt added a commit that referenced this issue Apr 18, 2017
Use UTC for timestamp in convertToDebianVersion. Closes #238
Repository owner deleted a comment from Pham1993 Mar 9, 2024
Repository owner deleted a comment from Pham1993 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants