Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you add support for vertexColors? #11

Open
wjessup opened this issue Jul 24, 2019 · 6 comments
Open

can you add support for vertexColors? #11

wjessup opened this issue Jul 24, 2019 · 6 comments

Comments

@wjessup
Copy link

wjessup commented Jul 24, 2019

This is required when there's a MeshStandardMaterial and the geometry has a colors array.

@wjessup
Copy link
Author

wjessup commented Jul 24, 2019

You can test with these models to see that they don't work as-is: https://supermedium.com/craft/fierce-talk

@wjessup
Copy link
Author

wjessup commented Jul 24, 2019

@tdhooper I took a shot at it here: https://gist.github.com/wjessup/5102b5c4b955f2bb3bd35495d1ca350d

The order is messed up but some of the colors are working!

If you have any time to help, that would be awesome :)

@wjessup
Copy link
Author

wjessup commented Jul 24, 2019

model is sliced up into many pieces, and some of them put back together:

image

@tdhooper
Copy link
Owner

Hey, thanks for having a go at this, could you create a pull request so I can see what you changed?

And do you have a simpler model, so it's easier to see any errors?

@wjessup
Copy link
Author

wjessup commented Jul 28, 2019

done! #12

@wjessup
Copy link
Author

wjessup commented Jul 28, 2019

As for the model — try anything from https://supermedium.com/supercraft/ (scroll down and you can browse models to try out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants