Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace derive and satisfies #1057

Open
madvorak opened this issue Jan 21, 2025 · 1 comment
Open

Namespace derive and satisfies #1057

madvorak opened this issue Jan 21, 2025 · 1 comment

Comments

@madvorak
Copy link
Contributor

I don't think that derive and satisfies should be declared in the global namespace.

inductive derive.{u} {α : Type u} (Γ : Ctx α) : MagmaLaw α → Type u where

def satisfies {α} (G) [Magma G] (E : MagmaLaw α) := ∀ (φ : α → G), satisfiesPhi φ E

I suggest MagmaLaw.derive and MagmaLaw.satisfies as better names.

PS: I don't see a point of MagmaLaw being inside Law itself. However, it is another story.

@teorth
Copy link
Owner

teorth commented Jan 21, 2025

Provided that the refactor can be done easily, I have no objection to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants