change of ll_to_earth function on AWS, must be owner of function

[radi334]

Describe the bug

During deployment of teslamate Docker app in AWS ECS/AWS RDS postgresql as DB backend service, I retrieved the error:
** (Postgrex.Error) ERROR 42501 (insufficient_privilege) must be owner of function ll_to_earth when SQL
"CREATE OR REPLACE FUNCTION public.ll_to_earth(float8, float8)\nRETURNS public.earth\nLANGUAGE SQL\nIMMUTABLE STRICT\nPARALLEL SAFE\nAS 'SELECT public.cube(public.cube(public.cube(public.earth()*cos(radians($1))*cos(radians($2))),public.earth()*cos(radians($1))*sin(radians($2))),public.earth()*sin(radians($1)))::public.earth';\n"
is executed

This function seems to be owned by standard user rdsadmin, and not by the user teslamate is configured in.

I changed the owner of the function on postgres manually, after that SQL worked.

Expected behavior

Initial installation process should runs smooth without intervention.

1. make sure infrastructure including Postgresql is setup in AWS including log group
2. start docker container which is provided by docker hub
3. application does not startup
4. retrieve logs from Cloud formation

Relevant entries from the logs

---

timestamp	message
1602831511960	06:58:31.958 [info] == Running 20191008191431 TeslaMate.Repo.Migrations.FixLlToEarth.up/0 forward
1602831511961	06:58:31.961 [info] execute "CREATE OR REPLACE FUNCTION public.ll_to_earth(float8, float8)\nRETURNS public.earth\nLANGUAGE SQL\nIMMUTABLE STRICT\nPARALLEL SAFE\nAS 'SELECT public.cube(public.cube(public.cube(public.earth()*cos(radians($1))*cos(radians($2))),public.earth()*cos(radians($1))*sin(radians($2))),public.earth()*sin(radians($1)))::public.earth';\n"
1602831512058	** (Postgrex.Error) ERROR 42501 (insufficient_privilege) must be owner of function ll_to_earth
1602831512058	(ecto_sql 3.5.0) lib/ecto/adapters/sql.ex:683: Ecto.Adapters.SQL.raise_sql_call_error/1
1602831512058	(elixir 1.10.4) lib/enum.ex:1396: Enum."-map/2-lists^map/1-0-"/2
1602831512058	(ecto_sql 3.5.0) lib/ecto/adapters/sql.ex:770: Ecto.Adapters.SQL.execute_ddl/4
1602831512058	(ecto_sql 3.5.0) lib/ecto/migration/runner.ex:343: Ecto.Migration.Runner.log_and_execute_ddl/3
1602831512058	(ecto_sql 3.5.0) lib/ecto/migration/runner.ex:117: anonymous fn/6 in Ecto.Migration.Runner.flush/0
1602831512058	(elixir 1.10.4) lib/enum.ex:2111: Enum."-reduce/3-lists^foldl/2-0-"/3
1602831512058	(ecto_sql 3.5.0) lib/ecto/migration/runner.ex:116: Ecto.Migration.Runner.flush/0
1602831512058	(ecto_sql 3.5.0) lib/ecto/migration/runner.ex:280: Ecto.Migration.Runner.perform_operation/3

---

Environment

• TeslaMate version: 1.20.0
• Type of installation: Docker on AWS ECS
• OS TeslaMate is installed on: Elastic Cloud Container service
• User OS & Browser: Windows, Google Chrome
• Others: PostgreSQL version 11.5

[dyxyl]

I suspect the problem is that your teslamate user is not a superuser. The "Manual Install" instructions say that this is required during the migration step. In the standard "Docker Install" instructions, the teslamate user is the superuser.

[radi334]

I would guess it is superuser:

teslamate | Create role, Create DB +| {rds_superuser}

I was also able with this user to change the ownership of the respective function.
However, what I don't get, why to change a builtin function and not create your own.

[dyxyl]

According to the docs, the superuser attribute is never inherited (see https://www.postgresql.org/docs/current/role-membership.html).

I don't know why a new function wasn't created, but I suppose it would have been more work to fix all of the users.