Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to disable on_error sound #75

Open
3 tasks done
jhbruhn opened this issue Aug 9, 2024 · 1 comment
Open
3 tasks done

Ability to disable on_error sound #75

jhbruhn opened this issue Aug 9, 2024 · 1 comment

Comments

@jhbruhn
Copy link
Contributor

jhbruhn commented Aug 9, 2024

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

When multiple onju voices detect the wakeword at the same time, HA cancels all but one pipelines (good!). This triggers the on_error handler on the cancelled devices though, which then play the on_error sound.

Describe the solution you'd like

A runtime configuration switch which allows turning off of the on_error sound.

Describe alternatives you've considered

It would be nice if HA would allow a differentiation between error types, but I don't think it does? Then we could choose when to play the sound.

Additional context

@tetele
Copy link
Owner

tetele commented Aug 9, 2024

I think this should be fixed in ESPHome rather than the config. I will look into it when i get back from vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants