Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests for aorsf version 0.1.2 #287

Closed
bcjaeger opened this issue Dec 28, 2023 · 4 comments
Closed

update tests for aorsf version 0.1.2 #287

bcjaeger opened this issue Dec 28, 2023 · 4 comments

Comments

@bcjaeger
Copy link
Contributor

bcjaeger commented Dec 28, 2023

Hello!

I am planning to release aorsf version 0.1.2 soon, and this update will provide support for both classification and regression oblique random forests. Internally, I've re-worked some of the attributes and class types of aorsf, which means the new version will break some of the tests in test-rand_forest_aorsf.R. I've prepared a pull request with minor changes to this file that will make it compatible with 0.1.2. Would it be okay if I submitted this PR for you to review?

I'd be happy to add some additional code in this PR to resolve #283 if you'd like! Just let me know.

edit: my mistake, version 0.1.2

@bcjaeger bcjaeger changed the title update tests for aorsf version 1.1.2 update tests for aorsf version 0.1.2 Dec 28, 2023
@EmilHvitfeldt
Copy link
Member

Hello @bcjaeger 👋

Thanks for the heads up! The PR is highly welcomed! We are all out-of-office between Christmas and new years, but we will look at it once we are back!

@bcjaeger
Copy link
Contributor Author

Excellent, thank you! I appreciate the reply and hope you are having a lovely time away.

@hfrick
Copy link
Member

hfrick commented Jan 5, 2024

closed in #288

@hfrick hfrick closed this as completed Jan 5, 2024
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants