feat: allow movable workerData
#27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
commented
Mar 18, 2022
| * Handle transferable `data` or transferable properties of `data` by unwrapping | ||
| * them and adding their transferable objects to the given `transferList` array. | ||
| */ | ||
| function fillTransferList(data: any, transferList: TransferListItem[]): any { |
There was a problem hiding this comment.
Here's the star of the show. The rest is mainly TypeScript improvements.
aleclarson
commented
Mar 18, 2022
| @@ -254,23 +245,8 @@ class TaskInfo extends AsyncResource implements Task { | |||
| ) { | |||
| super('Tinypool.Task', { requireManualDestroy: true, triggerAsyncId }) | |||
| this.callback = callback | |||
| this.task = task | |||
| this.task = fillTransferList(task, transferList) | |||
There was a problem hiding this comment.
This PR also adds nested movable support to the pool.run method. ☝️
Note that only 1 level of nesting is checked. In other words, doing this 👇 is not supported:
pool.run({ a: { b: Tinypool.move(b) } })
aleclarson
commented
Mar 18, 2022
| @@ -3,6 +3,7 @@ import { | |||
| MessageChannel, | |||
| MessagePort, | |||
| receiveMessageOnPort, | |||
| TransferListItem, | |||
There was a problem hiding this comment.
Turns out worker_threads exports a TransferListItem type for us, so we don't have to extract it from MessagePort.postMessage anymore :)
|
@aleclarson Thank you, Alec, This looks good overall, though, we need to add tests for it and a short description in README! |
aleclarson
force-pushed
the
feat/movable-workerData
branch
from
ea8fa68 to
b68456b
Compare
|
@aleclarson Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26