Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: romanization issues with epenthetic "n" #318

Open
thomasst opened this issue Jan 16, 2025 · 1 comment
Open

[Bug]: romanization issues with epenthetic "n" #318

thomasst opened this issue Jan 16, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@thomasst
Copy link

Bug description

It appears that some words are not romanized correctly and an epenthetic "n" is inserted incorrectly. For example, the word "호랑이" should be romanized as "horangi", not "horangni". This also matches the romanization obtained at http://roman.cs.pusan.ac.kr/input_eng.aspx

Expected behavior

Current:

console.log(romanize('호랑이')); // "horangni"
console.log(romanize('빨간색이에요')); // "ppalgansaengnieyo"

Expected:

console.log(romanize('호랑이')); // "horangi"
console.log(romanize('빨간색이에요')); // "ppalgansaegieyo"

To Reproduce

No response

Possible Solution

No response

etc.

No response

@thomasst thomasst added the bug Something isn't working label Jan 16, 2025
@thomasst thomasst changed the title [Bug]: romanization issues [Bug]: romanization issues with epenthetic "n" Jan 16, 2025
@wet6123
Copy link
Contributor

wet6123 commented Jan 19, 2025

This issue seems to come from 'standardizePronunciation'.
And I found some extra cases.

// 단일 형태소는 ㄴ첨가가 일어나지 않음
expect(standardizePronunciation('호랑이')).toBe('호랑이'); //but 호랑니
expect(standardizePronunciation('공이')).toBe('공이'); // but 공니
// ㄴㄴ 첨가
expect(standardizePronunciation('나뭇잎')).toBe('나문닙'); // but 나무십
// 수의적 표현
expect(standardizePronunciation('첫인상')).toBe('처딘상'); // but 처신쌍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants