Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all ActiveJobs to Sidekiq jobs #690

Open
kitallis opened this issue Nov 26, 2024 · 2 comments
Open

Migrate all ActiveJobs to Sidekiq jobs #690

kitallis opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels
gitstart tickets for GitStart to pick up

Comments

@kitallis
Copy link
Member

kitallis commented Nov 26, 2024

Context

This is a pure technical debt requirement. All our background jobs are run through the sidekiq adaptor. But many of the jobs do not inherit from ActiveJob, but instead just call include Sidekiq::Job.

Sidekiq jobs have a lot more control and testing ease than active job counterparts, in general. So we should move them all to be consistent, and actually move to include Sidekiq::Job instead.

Requirements & acceptance criteria

Move all jobs to include Sidekiq::Job. Do this by changing ApplicationJob to simply include it and have all jobs inherit from ApplicationJob.

This would broadly require:

  • changing the call-sites to be perform_async rather than perform_later
  • fixing tests for the jobs

Additional notes

This will also allow us to add more details for sentry exceptions, because we can write Sidekiq middlewares to do that.

@kitallis kitallis added the gitstart tickets for GitStart to pick up label Nov 26, 2024
Copy link

Issue synced into GitStart. Please review, edit and hand it off to GitStart by following this link.

Copy link

This issue has been handed off to GitStart: https://clients.gitstart.com/tramline/11653/tickets/TRAB-690

@nid90 nid90 self-assigned this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitstart tickets for GitStart to pick up
Projects
None yet
Development

No branches or pull requests

2 participants