Nalu nightly diffs due to Muelu Ifpack2 Chebyshev commit

[spdomin]

Diffs in two Nalu Nightly tests: actuatorLine, oversetHybrid

git bisect good 7f1913d6657f3c5cbea0de80f8d21d7a26b64432
git bisect bad 16e7301c09a891cc309b2cb26e5ad17e03605d5a

@cgcgcg and @jhux2 :

commit f43dfacec5270b24afff14bb5ac27130d8b5cbc8
Author: Christian Glusa <[email protected]>
Date:   Sun Feb 18 18:12:49 2024 -0700

    MueLu Ifpack2 Chebyshev: Enable use with Operator

:040000 040000 698dfbc242a23cad3ade2cb3bde187e969d2155b 277fb4cd50f74bf7e186f925a6d8a569f06411b5 M	packages

Please advise if this change was intentional and I should re-bless the tests. Timings look roughly the same.

[github-actions]

Automatic mention of the @trilinos/muelu team

[github-actions]

Automatic mention of the @trilinos/ifpack2 team

[spdomin]

git bisect start
# bad: [16e7301c09a891cc309b2cb26e5ad17e03605d5a] Merge Pull Request #12756 from cgcgcg/Trilinos/complexFloatFix
git bisect bad 16e7301c09a891cc309b2cb26e5ad17e03605d5a
# good: [7f1913d6657f3c5cbea0de80f8d21d7a26b64432] Merge Pull Request #12748 from trilinos/Trilinos/csiefer2-readme
git bisect good 7f1913d6657f3c5cbea0de80f8d21d7a26b64432
# good: [398f1ad974609d4d05bb44f87dd757a392a04bbb] Merge Pull Request #12755 from cgcgcg/Trilinos/complexFloatFix
git bisect good 398f1ad974609d4d05bb44f87dd757a392a04bbb
# bad: [7c3e3b4221ba6a7da93d1c42cc05b05eb531a6fd] Merge Pull Request #12753 from cgcgcg/Trilinos/mueluFixes
git bisect bad 7c3e3b4221ba6a7da93d1c42cc05b05eb531a6fd
# good: [89f26b3824ab43f2e6636e4f3ccbebe68f353e1b] MueLu Ifpack2: Fix inefficiency in Hiptmair with Chebyshev sub-smoothers
git bisect good 89f26b3824ab43f2e6636e4f3ccbebe68f353e1b
# bad: [f43dfacec5270b24afff14bb5ac27130d8b5cbc8] MueLu Ifpack2 Chebyshev: Enable use with Operator
git bisect bad f43dfacec5270b24afff14bb5ac27130d8b5cbc8
# good: [1f2cc316e4804138a9341518ca96f73e2c059b0a] MueLu: Fix bad SubFactoryMonitors
git bisect good 1f2cc316e4804138a9341518ca96f73e2c059b0a
# first bad commit: [f43dfacec5270b24afff14bb5ac27130d8b5cbc8] MueLu Ifpack2 Chebyshev: Enable use with Operator

[jhux2]

@spdomin Can you post the residual diffs, or a link to them? Thanks.

[spdomin]

They are small - order of operations-like diffs, i.e., 1.0e-6. Moreover, only two out of the ~80 tests diffed.

[jhux2]

@spdomin I'm going to say this is a benign diff. There was a change in the scalar type of a Chebyshev parameter in the commit your bisect flagged.

[spdomin]

Okay, I can re-bless if this is your suggestion:)

[spdomin]

I will close this tomorrow - assuming a clean test result. Best,

[cgcgcg]

@spdomin May we close this issue?

[spdomin]

Yes.