CompatHelper: bump compat for CairoMakie to 0.13 for package test, (keep existing compat) #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…eep existing compat)
sloede
force-pushed
the
compathelper/new_version/2025-01-18-00-27-59-315-02036559642
branch
from
de5f01e to
8e39ec3
Compare
|
Blocked by SciML/SciMLBase.jl#905 |
efaulhaber
added
low priority
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 68.73% 68.73%
=======================================
Files 93 93
Lines 5780 5780
=======================================
Hits 3973 3973
Misses 1807 1807
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svchb
previously approved these changes
Jan 22, 2025
efaulhaber
reviewed
Jan 22, 2025
test/Project.toml
Outdated
| @@ -16,7 +16,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | |||
|
|
|||
| [compat] | |||
| CSV = "0.10" | |||
| CairoMakie = "0.12" | |||
| CairoMakie = "0.12, 0.13" | |||
There was a problem hiding this comment.
Suggested change
| CairoMakie = "0.12, 0.13" | |
| CairoMakie = "0.13" |
Is there a reason why we would need 0.12 now?
There was a problem hiding this comment.
No but:
- This is just the default CompatHelper
- Both versions are still working since we don't use any specific part of 0.13
There was a problem hiding this comment.
Let's see if 0.13 now works.
|
Apparently, there are still some incompatibilities with 0.13. I commented here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
CairoMakiepackage from0.12to0.12, 0.13for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.