Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental warnings before release #36

Open
patrickersing opened this issue Apr 2, 2024 · 1 comment
Open

Update experimental warnings before release #36

patrickersing opened this issue Apr 2, 2024 · 1 comment

Comments

@patrickersing
Copy link
Contributor

Before making a first release we need to update the experimental warnings.
Especially with the new features, that are about to be introduced with the multilayer equations in #30, we have to discuss which functions need to be experimental.

@andrewwinters5000
Copy link
Member

This is particularly relevant toward the upcoming extension of the positivity limiter to the multi-layer equations. Abstracting the fluxes and water heights to enable easy iteration over nlayers should make the syntax of applying the limiter much easier compared to the current naming and storage conventions used in ShallowWaterTwoLayerEquations1D and ShallowWaterTwoLayerEquations2D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants