You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using '.reek.yml' as configuration file.
Inspecting 1 file(s):
.
Possible Bug
When linting through atom-linter, the current working directory (cwd) is set to the one the file being linted exists, in this case: app/helpers. Reek will still find the correct .reek.yml from it's ancestors, first in app and ultimately on the project's root. But, it won't match the directory "app/helpers", because it's looking for "app/helpers" relative to the cwd instead of relative to the configuration file.
cd app/helpers
reek --show-configuration-path foo_helper.rb
Using '../../.reek.yml' as configuration file.
Inspecting 1 file(s):
S
foo_helper.rb -- 1 warning:
[5]:UtilityFunction: FooHelper#smelly_method doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/v5.4.0/docs/Utility-Function.md]
I'm on reek 5.4.0
The text was updated successfully, but these errors were encountered:
Setup
Rails app, where helpers smell of UtilityFunction
.reek.yml
app/helpers/foo_helper.rb
Happy Path
Possible Bug
When linting through atom-linter, the current working directory (cwd) is set to the one the file being linted exists, in this case: app/helpers. Reek will still find the correct .reek.yml from it's ancestors, first in app and ultimately on the project's root. But, it won't match the directory
"app/helpers"
, because it's looking for"app/helpers"
relative to the cwd instead of relative to the configuration file.cd app/helpers reek --show-configuration-path foo_helper.rb
I'm on reek 5.4.0
The text was updated successfully, but these errors were encountered: