Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133460 / 25.04 / Confirm Password shows error message even if I haven't touched it yet #11326

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Jan 13, 2025

Testing: see ticket.

Result:

Screen.Recording.2025-01-13.at.13.45.03.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Jan 13, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 13, 2025 11:45
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team January 13, 2025 11:45
@bugclerk bugclerk changed the title NAS-133460: Confirm Password shows error message even if I haven't touched it yet NAS-133460 / 25.04 / Confirm Password shows error message even if I haven't touched it yet Jan 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (1db0212) to head (35a422c).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11326   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files        1654     1654           
  Lines       59133    59135    +2     
  Branches     6217     6219    +2     
=======================================
+ Hits        48932    48937    +5     
+ Misses      10201    10198    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, red validation message appears only after user has touched to field

@AlexKarpov98 AlexKarpov98 merged commit fec317d into master Jan 15, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133460 branch January 15, 2025 09:05
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants