Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcb_plated_hole oval shape is missing #60

Closed
imrishabh18 opened this issue Sep 10, 2024 · 3 comments
Closed

pcb_plated_hole oval shape is missing #60

imrishabh18 opened this issue Sep 10, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@imrishabh18
Copy link
Member

imrishabh18 commented Sep 10, 2024

Screenshot 2024-09-11 at 12 58 08 AM
[
          {
            type: "source_component",
            source_component_id: "generic_0",
            supplier_part_numbers: {},
          },
          {
            type: "schematic_component",
            schematic_component_id: "schematic_generic_component_0",
            source_component_id: "generic_0",
            center: { x: 0, y: 0 },
            rotation: 0,
            size: { width: 0, height: 0 },
          },
          {
            type: "pcb_component",
            source_component_id: "generic_0",
            pcb_component_id: "pcb_generic_component_0",
            layer: "top",
            center: { x: 0, y: 0 },
            rotation: 0,
            width: 0,
            height: 0,
          },
          {
            type: "pcb_plated_hole",
            x: 0,
            y: 0,
            layers: ["top", "bottom"],
            outer_width: 2.6,
            outer_height: 3.78,
            hole_width: 1.1,
            hole_height: 2.28,
            shape: "pill",
            port_hints: [],
            pcb_component_id: "pcb_generic_component_0",
          },
          {
            type: "pcb_silkscreen_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            pcb_silkscreen_path_id: "pcb_silkscreen_path_0",
            route: [
              { x: -0.515, y: 6.46 },
              { x: -0.515, y: 2.125 },
            ],
            stroke_width: 0.1,
          },
          {
            type: "pcb_silkscreen_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            pcb_silkscreen_path_id: "pcb_silkscreen_path_1",
            route: [
              { x: -0.515, y: 6.46 },
              { x: 12.405, y: 7.35 },
            ],
            stroke_width: 0.1,
          },
          {
            type: "pcb_silkscreen_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            pcb_silkscreen_path_id: "pcb_silkscreen_path_2",
            route: [
              { x: -0.515, y: -2.1 },
              { x: -0.515, y: -6.46 },
            ],
            stroke_width: 0.1,
          },
          {
            type: "pcb_silkscreen_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            pcb_silkscreen_path_id: "pcb_silkscreen_path_3",
            route: [
              { x: -0.515, y: -6.46 },
              { x: 12.405, y: -7.35 },
            ],
            stroke_width: 0.1,
          },
          {
            type: "pcb_silkscreen_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            pcb_silkscreen_path_id: "pcb_silkscreen_path_4",
            route: [
              { x: 12.405, y: 7.35 },
              { x: 12.405, y: -7.35 },
            ],
            stroke_width: 0.1,
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_0",
            route: [
              { x: -0.405, y: 6.35 },
              { x: -0.405, y: -6.35 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_1",
            route: [
              { x: -0.405, y: 6.35 },
              { x: 12.295, y: 7.24 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_2",
            route: [
              { x: 0.405, y: 5.597 },
              { x: 0.405, y: -5.597 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_3",
            route: [
              { x: 0.405, y: 5.597 },
              { x: 12.295, y: 6.43 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_4",
            route: [
              { x: 12.295, y: 7.24 },
              { x: 12.295, y: -7.24 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_5",
            route: [
              { x: 12.295, y: -7.24 },
              { x: -0.405, y: -6.35 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_path",
            layer: "top",
            pcb_component_id: "pcb_generic_component_0",
            fabrication_note_path_id: "fabrication_note_path_6",
            route: [
              { x: 12.3, y: -6.43 },
              { x: 0.405, y: -5.597 },
            ],
            stroke_width: 0.1,
            port_hints: [],
          },
          {
            type: "pcb_silkscreen_text",
            layer: "top",
            font: "tscircuit2024",
            font_size: 1,
            pcb_component_id: "pcb_generic_component_0",
            anchor_position: { x: 6.35, y: 0 },
            anchor_alignment: "center",
            text: "${REFERENCE}",
          },
          {
            type: "pcb_fabrication_note_text",
            layer: "top",
            font: "tscircuit2024",
            font_size: 1.27,
            pcb_component_id: "pcb_generic_component_0",
            anchor_position: { x: 6.35, y: 8.5 },
            anchor_alignment: "center",
            text: "REF**",
            port_hints: [],
          },
          {
            type: "pcb_fabrication_note_text",
            layer: "top",
            font: "tscircuit2024",
            font_size: 1.27,
            pcb_component_id: "pcb_generic_component_0",
            anchor_position: { x: 6.35, y: -8.5 },
            anchor_alignment: "center",
            text: "Heatsink_AAVID_576802B03900G",
            port_hints: [],
          },
        ]
@imrishabh18 imrishabh18 added the good first issue Good for newcomers label Sep 10, 2024
Copy link

homie-gg bot commented Sep 10, 2024

This might be a duplicate of: Add pcb_plated_hole.pcb_plated_hole_id.

Copy link

homie-gg bot commented Sep 10, 2024

This might have already been done via: add some default connectedTo ids for obstacles.

Copy link

homie-gg bot commented Sep 10, 2024

Here are some pull requests that might be helpful reference for this task:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant