Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Information: Compatibility with React Native's New Architecture #452

Open
3 tasks done
rhoberman opened this issue Nov 18, 2024 · 3 comments
Open
3 tasks done
Assignees

Comments

@rhoberman
Copy link

Request for Information: Compatibility with React Native's New Architecture

Pre-submission Checklist

  • I have verified that the issue is not marked as a known limitation in the CHANGELOG.md.
  • I reviewed the Common Issues and open GitHub issues to check if this topic has been addressed.
  • I am not sharing any [Personally Identifiable Information (PII)] or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Description

I am considering migrating my React Native project to the New Architecture (Fabric and TurboModules) for improved performance and maintainability. Before proceeding, I wanted to confirm the compatibility of the twilio-voice-react-native SDK with the New Architecture.

I noticed the flag newArchEnabled=false in the SDK configuration, which suggests that the SDK may not currently support the New Architecture. Could you please provide clarification on the following:

  1. Is the Twilio Voice React Native SDK compatible with React Native's New Architecture as of the latest release?
  2. If not, is there a timeline or plan for supporting the New Architecture in future versions of the SDK?
  3. Are there any known issues or workarounds for using the SDK in a project that has enabled the New Architecture?

Expected Outcome

I am looking for guidance on whether the SDK can be used with the New Architecture or if I should hold off on migrating my project until official support is announced.

Software and Device Information

  • React Native version: 0.75.4
  • Twilio Voice React Native SDK version: 1.2.1

Additional Context

None

@mhuynh5757
Copy link
Collaborator

Hi @rhoberman I've filed an internal ticket to investigate the New Architecture and exactly where our SDK stands on that. Please stay tuned, sorry I don't have more information immediately available for you now.

@mhuynh5757 mhuynh5757 pinned this issue Dec 3, 2024
@mhuynh5757 mhuynh5757 self-assigned this Dec 3, 2024
@mhuynh5757
Copy link
Collaborator

Hi @rhoberman can I ask you a few questions about your use-case actually? As I'm scoping out NewArch support for our SDK, as well as Expo support, I'd like to know how the community is using our library. Since the ReactNative team has officially recommended Expo and NewArch as the new defaults, it would be nice to know if this is the standard that we should target moving forward. Thanks for any and all feedback you're willing to share.

@rhoberman
Copy link
Author

Hi @mhuynh5757,

Thanks for following up on my question. To answer your query, we use vanilla React Native, not Expo. I wasn’t part of the team when the app was originally started in 2019, so I can’t speak to the specific reasoning behind choosing vanilla React Native at the time. Personally, I tend to prefer vanilla systems over frameworks due to my own experiences and preferences. However, I can’t comment on what would best serve the broader community.

I’ve recently replaced our Twilio integration with your SDK, and I have to say it’s been fantastic. It’s working smoothly and has significantly simplified our codebase. I truly appreciate the high quality of your library and the effort behind it.

That said, support for NewArch in vanilla React Native is critical for us. Without it, we anticipate challenges in staying compatible with newer versions of other libraries. Moving to Expo would also likely be a distraction that we can’t afford at this time.

I’m happy to provide additional details about our use case or discuss further if that would be helpful. Let me know how I can assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants