Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider GitHub workflows to monitor failing installation processes #636

Closed
ras44 opened this issue Jul 12, 2023 · 1 comment
Closed

Consider GitHub workflows to monitor failing installation processes #636

ras44 opened this issue Jul 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ras44
Copy link
Collaborator

ras44 commented Jul 12, 2023

Describe the bug
While troubleshooting installation issues, I ended up adding some GitHub workflows to make each of the installation options in the README a reproducible process.

These include:

  • Install from conda-forge action Test conda-forge install
  • Install with the conda virtual environment action Test conda-venv install
  • Install from PyPI action Test PyPI install
  • Install from source action build

Some of the installation processes described in the README at: https://github.com/ras44/causalml#installation
are failing.

Build/install issues are mentioned in #624, #609, #593, #533, #534, and it may help user experience to have a reproducible workflow that illustrates they are building correctly (and how to build them).

To Reproduce
See the github workflows linked to above to reproduce.

Expected behavior
Following install instructions should create prod/dev environments without issues.

Have the README instructions for:

  • Install from conda-forge
  • Install with the conda virtual environment
  • Install from PyPI
  • Install from source

match a reproducible GitHub workflows that are passing, to build user confidence and avoid abandonment.

Environment (please complete the following information):

  • OS: [Windows, Ubuntu]
  • Python Version: [3.7, 3.8, 3.9]

Additional context

Does it sound like a reasonable plan to build GitHub actions that reproduce these install scenarios?

The idea is that they should all pass, and that the README instructions can then either reference them or copy them for the end user to use in a prod or dev setting.

@ras44 ras44 added the bug Something isn't working label Jul 12, 2023
@ras44 ras44 changed the title Current installation processes fail Consider GitHub workflows to monitor failing installation processes Jul 12, 2023
@ras44
Copy link
Collaborator Author

ras44 commented Jul 13, 2023

Currently, all 6 py x tf conda envs build successfully, but tests fail:

https://github.com/ras44/causalml/actions/runs/5546320526/jobs/10126438492

Building from source for py [3.6, 3.7, 3.8] using the dependencies defined in pyproject.toml succeeds and tests succeed:

https://github.com/ras44/causalml/actions/runs/5546201960

@ras44 ras44 closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant