From c311b4f9e116b0febe1884f73d7d55d0060904c0 Mon Sep 17 00:00:00 2001
From: Rob Knight <raknight@ucsc.edu>
Date: Fri, 12 Apr 2024 15:12:10 -0700
Subject: [PATCH] =?UTF-8?q?fix:=20=F0=9F=9A=91=EF=B8=8F=20Fix=20two=20issu?=
 =?UTF-8?q?es=20introduced=20by=20breadcrumbs=20changes?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The breadcrumbs change added a child element to the `wp-blocks` container. In it's grid template style rule, we only accounted for three children, not four. This change fixes that, and adjusts the breadcrumbs parent element from `div` to `section` in the templates
---
 src/scss/base/_layout.scss   | 4 ++++
 templates/404.html           | 4 ++--
 templates/archive.html       | 4 ++--
 templates/category.html      | 4 ++--
 templates/home.html          | 4 ++--
 templates/index.html         | 4 ++--
 templates/page-no-title.html | 4 ++--
 templates/page.html          | 4 ++--
 templates/search.html        | 4 ++--
 templates/single.html        | 4 ++--
 10 files changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/scss/base/_layout.scss b/src/scss/base/_layout.scss
index 2b385f29..553e9791 100644
--- a/src/scss/base/_layout.scss
+++ b/src/scss/base/_layout.scss
@@ -12,6 +12,10 @@ body {
 	flex: 1 0 auto;
 	display: grid;
 	grid-template-rows: auto 1fr auto;
+
+	&:has(.breadcrumbs-region) {
+		grid-template-rows: auto auto 1fr auto;
+	}
 }
 
 .editor-styles-wrapper {
diff --git a/templates/404.html b/templates/404.html
index b05075fe..a216e4cf 100644
--- a/templates/404.html
+++ b/templates/404.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true}} -->
 <main class="wp-block-group content-region">
@@ -27,4 +27,4 @@ <h1 class="entry-title">
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/archive.html b/templates/archive.html
index 9f3258a4..3efa8426 100644
--- a/templates/archive.html
+++ b/templates/archive.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|50"}}},"className":"content-region","layout":{"inherit":true}} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--50)">
@@ -11,4 +11,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/category.html b/templates/category.html
index 2d3549fd..ae25b3bb 100644
--- a/templates/category.html
+++ b/templates/category.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true,"type":"constrained"}} -->
 <main class="wp-block-group content-region">
@@ -23,4 +23,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/home.html b/templates/home.html
index e6d38d36..10204425 100644
--- a/templates/home.html
+++ b/templates/home.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"inherit":true,"type":"constrained"}} -->
 <main class="wp-block-group content-region">
@@ -28,4 +28,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/index.html b/templates/index.html
index 0c769658..2072c42f 100644
--- a/templates/index.html
+++ b/templates/index.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|50"}}},"className":"content-region"} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--50)">
@@ -7,4 +7,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/page-no-title.html b/templates/page-no-title.html
index b9abfc00..d88d3fb8 100644
--- a/templates/page-no-title.html
+++ b/templates/page-no-title.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main", "className":"content-region"} -->
 <main class="wp-block-group content-region">
@@ -9,4 +9,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/page.html b/templates/page.html
index a6a3dbc7..fb7fb830 100644
--- a/templates/page.html
+++ b/templates/page.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","style":{"spacing":{"margin":{"top":"var:preset|spacing|40"}}},"className":"content-region"} -->
 <main class="wp-block-group content-region" style="margin-top:var(--wp--preset--spacing--40)">
@@ -15,4 +15,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/search.html b/templates/search.html
index 122b3051..e624959f 100644
--- a/templates/search.html
+++ b/templates/search.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region"} -->
 <main class="wp-block-group content-region">
@@ -17,4 +17,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file
diff --git a/templates/single.html b/templates/single.html
index 0794a2a6..0cedde97 100644
--- a/templates/single.html
+++ b/templates/single.html
@@ -1,5 +1,5 @@
 <!-- wp:template-part {"slug":"header","theme":"ucsc-2022","tagName":"header","className":"header-region"} /-->
-<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","className":"breadcrumbs-region"} /-->
+<!-- wp:template-part {"slug":"breadcrumbs","theme":"ucsc-2022","tagName":"section","className":"breadcrumbs-region"} /-->
 
 <!-- wp:group {"tagName":"main","className":"content-region","layout":{"type":"default"}} -->
 <main class="wp-block-group content-region">
@@ -67,4 +67,4 @@
 </main>
 <!-- /wp:group -->
 
-<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
+<!-- wp:template-part {"slug":"footer","theme":"ucsc-2022","tagName":"footer","className":"footer-region"} /-->
\ No newline at end of file