Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect rendering of exercise in episode 5 #2

Open
olexandr-konovalov opened this issue Jun 4, 2024 · 4 comments
Open

Incorrect rendering of exercise in episode 5 #2

olexandr-konovalov opened this issue Jun 4, 2024 · 4 comments

Comments

@olexandr-konovalov
Copy link
Member

Screenshot 2024-06-04 at 08 33 05
@olexandr-konovalov
Copy link
Member Author

To fix, we should format the text it in a way that the entire code block has the same indentation. See swcarpentry#984 by @tobyhodges fixing this in another episode.

olexandr-konovalov pushed a commit that referenced this issue Oct 1, 2024
@tobyhodges
Merge pull request #2 from swcarpentry-i18n/merge-upstream-jul24
a11734e 
Merge upstream changes
@olexandr-konovalov
Copy link
Member Author

This still happens in https://ukrainian-carpentries.github.io/git-novice/05-history.html

olexandr-konovalov added a commit to olexandr-konovalov/git-novice that referenced this issue Nov 14, 2024
@olexandr-konovalov
Align indentation
ba8d0fa 
This should fix issues with incorrect rendering of translated lessons (ukrainian-carpentries#2)
@olexandr-konovalov olexandr-konovalov mentioned this issue Nov 14, 2024
Merged
@olexandr-konovalov
Copy link
Member Author

I have submitted the fix at swcarpentry#1049 - of course, the upstream lesson is now using the Ratatouille restaurant scenario, while we here are at the "Wolfman & Dracula" story. If I will be unable to fix things in this repository, all will hopefully fit together when we will catch up with all recent updates in the upstream lesson.

@olexandr-konovalov
Copy link
Member Author

The fix at swcarpentry#1049 was merged, so it should eventually be propagated to our translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@olexandr-konovalov