Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing sigmoid layer in the neural predictor #2

Open
cardwing opened this issue Jul 12, 2020 · 3 comments
Open

Missing sigmoid layer in the neural predictor #2

cardwing opened this issue Jul 12, 2020 · 3 comments

Comments

@cardwing
Copy link

Hi, @ultmaster Firstly, thanks for your awesome reproduction work. It really helps! However, there is something I don't understand and want to discuss with you. In the original paper, they added the sigmoid layer to the output of the predictor to help constrain the prediction within [0.1, 1]. However, in the current codes, the sigmoid layer is missing since you used MSE loss to train the model (the prediction is within [0, 100]). From my perspective, maybe they used the BCE loss to train the model and used MSE to evaluate the final performance (the prediction needs to multiply the base accuracy). Is my understanding right? Your help is much appreciated.

@ultmaster
Copy link
Owner

Hi @cardwing. My bad. I re-read the paper and I think I completely missed that part. As I'm currently on some projects now and it takes a while to re-setup the environment, I was wondering if you had tried adding sigmoid and BCE loss. If you had, sharing experiment results would be highly appreciated. You can also submit a pull request if you feel interested.

@ultmaster
Copy link
Owner

By the way, I did normalization (to zero-mean and one-std) in my code. If sigmoid + BCE is actually better, any idea on why is that?

@cardwing
Copy link
Author

Currently, the performance of adding the sigmoid layer and using BCE loss is bad (mse loss on the testing set is around 7). I will share the results here if it outperforms the MSE loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants