Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more typedefs #16

Open
2 of 3 tasks
sritchie opened this issue Mar 31, 2022 · 2 comments
Open
2 of 3 tasks

add more typedefs #16

sritchie opened this issue Mar 31, 2022 · 2 comments
Assignees

Comments

@sritchie
Copy link
Collaborator

sritchie commented Mar 31, 2022

#25 Introduced infrastructure for typings. Remaining TODOs:

To-do:

  • add typings for mathBox options
  • finish manual typings for types.js
  • add more tests to types.spec.ts. Since that test file is written in typescript, if its tests pass, we can be confident in my manual typings.
@sritchie
Copy link
Collaborator Author

@ChristopherChudzicki we might be done with this, yeah?

@ChristopherChudzicki
Copy link
Collaborator

The types for types.js are not really done. A bunch are still any: https://github.com/unconed/mathbox/blob/master/src/primitives/types/types_typed.ts#L207-L222

I think this will be "done" when those are all finished. I'm pretty sure I'll add scale soon, and will look more closely at the others when I do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants