Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventStream.push hangs when called before eventStream.send() #944

Open
rrd108 opened this issue Jan 9, 2025 · 4 comments
Open

eventStream.push hangs when called before eventStream.send() #944

rrd108 opened this issue Jan 9, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@rrd108
Copy link

rrd108 commented Jan 9, 2025

Environment

node v20.13.0
h3: 1.13.0

Reproduction

https://github.com/rrd108/h3-eventstream-push-hang

Steps to reproduce:

Describe the bug

The eventStream.push method in h3 hangs indefinitely when called before the eventStream.send() method is invoked.

This prevents the server from sending the stream to the client and causes a stall. The issue occurs even with a single call to eventStream.push before send and it is not related to backpressure.
The WritableStream reports it's ready before the push, and the problem is present even if we await the ready promise before the write operation.

Additional context

No response

Logs

No response

@rrd108 rrd108 added the bug Something isn't working label Jan 9, 2025
@rrd108 rrd108 changed the title eventStream.push hangs when called multiple times before eventStream.send() eventStream.push hangs when called before eventStream.send() Jan 9, 2025
@Mittcio
Copy link
Contributor

Mittcio commented Jan 10, 2025

#940

@rrd108
Copy link
Author

rrd108 commented Jan 11, 2025

Thanks

@Mittcio
Copy link
Contributor

Mittcio commented Jan 11, 2025

@rrd108 do something?

@rrd108
Copy link
Author

rrd108 commented Jan 11, 2025

I solved it using the package you reccomended here #940 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants