Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor find_org_coc method #160

Open
MichaelJamesParsons opened this issue Sep 30, 2019 · 0 comments
Open

Refactor find_org_coc method #160

MichaelJamesParsons opened this issue Sep 30, 2019 · 0 comments
Assignees
@MichaelJamesParsons
Milestone
Titan 0.3 - Organ...

Comments

@MichaelJamesParsons
Copy link
Contributor

Description

The find_org_coc() function returns a models::ChainOfCommand struct that represents the org's CoC in two separate lists: extended_coc and local_coc. Refactor this method to return a single list ordered by the org's CoC.

[...localCoc, ...parentCoc, ...grandparentCoc, ...]

Additionally, the function eager loads associations. Refactor the code so eager loading is handled by the function callers instead of internally. Long term, eager loading will be extracted from all model functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelJamesParsons MichaelJamesParsons

Labels
None yet
Projects
None yet
Milestone
Titan 0.3 - Organization Management
Development

No branches or pull requests
1 participant
@MichaelJamesParsons