Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DRY principle in app/compile.py #4

Open
unownone opened this issue Sep 29, 2022 · 3 comments
Open

Implement DRY principle in app/compile.py #4

unownone opened this issue Sep 29, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@unownone
Copy link
Owner

Summary

The code we use to compile/interpret code snippets have not followed DRY (Don't Repeat yourself) Principles that well . A more functional( or OOP based , functional preferred though) approach towards compiling a code sample ( optional ) and running a code sample would yield a better code reusability metrics.

It should also help us cover more ground , i.e. support more languages.

Hints:

This can be achieved by breaking down compilation and running into two different functions followed by one function that will take in the language and code snippet, which would decide what needs to be done for the given language.

@unownone unownone added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Sep 29, 2022
@LyubomirT
Copy link

Hello! I created a fork of your repository with my attempt to implement this. Please review the fork repository and let me know if I can open a pull request with the changes.

@unownone
Copy link
Owner Author

unownone commented Oct 3, 2023

hey @LyubomirT great going buddy! can you already create a Pull request ? Then I can easily give you all the feedback and also review your code easily!

@LyubomirT
Copy link

Alright. The Pull Request's ready, you can find it here: #14

I am excited to be contributing to this project! I'm looking forward to your feedback and any suggestions you may have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants