Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of Type Hints in Code #4

Open
unownone opened this issue Sep 29, 2022 · 2 comments
Open

Lack of Type Hints in Code #4

unownone opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that accepts hacktoberfest prs.

Comments

@unownone
Copy link
Owner

Summary

There's a lack of type hints in the code which makes the code less readable.

Requirement:

To increase Code Quality , add type hints to the code to make the code more readable and debuggable!

Example :

#/app/auth.py
#python3.9
...
def login(user: User_dict, Authorize: AuthJWT = Depends()):
    hasher = Hasher()
...

here hasher = Hasher() can be changed into hasher:Hasher = Hasher()

@unownone unownone added enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that accepts hacktoberfest prs. labels Sep 29, 2022
@donheshanthaka
Copy link
Contributor

Hey there, i would be happy to contribute in this project. can you assign me to this issue?

@unownone
Copy link
Owner Author

@donheshanthaka Surely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that accepts hacktoberfest prs.
Projects
None yet
Development

No branches or pull requests

2 participants