Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting and coverage #3

Open
abrahamq opened this issue Sep 6, 2018 · 1 comment
Open

Add linting and coverage #3

abrahamq opened this issue Sep 6, 2018 · 1 comment
Assignees

Comments

@abrahamq
Copy link
Member

abrahamq commented Sep 6, 2018

we use eslint with google's linting package to maintain code consistency across the bots, see: https://github.com/urbanriskmap/cognicity-reports-facebook/blob/master/package.json \

for details

@abrahamq
Copy link
Member Author

abrahamq commented Sep 13, 2018

looks like there's now a eslint rc, but it doesn't pass + there's no npm lint script specified. Please let me know via slack if you have questions/ need help with anything

abrahamq@abrahamq-XPS-8700:~/cognicity-reports-line$ eslint src/

/home/abrahamq/cognicity-reports-line/src/config.js
   3:1  error  Unexpected var, use let or const instead       no-var
  12:1  error  Line 12 exceeds the maximum line length of 80  max-len

/home/abrahamq/cognicity-reports-line/src/function/receive/index.js
  1:1  error  Parsing error: The keyword 'import' is reserved

/home/abrahamq/cognicity-reports-line/src/lib/linebot.js
  1:1  error  Parsing error: The keyword 'import' is reserved

✖ 4 problems (4 errors, 0 warnings) ```

@abrahamq abrahamq reopened this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants