Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JRE generation task #163

Open
chippmann opened this issue Apr 21, 2021 · 3 comments · May be fixed by #740
Open

Implement JRE generation task #163

chippmann opened this issue Apr 21, 2021 · 3 comments · May be fixed by #740
Assignees

Comments

@chippmann
Copy link
Contributor

Best would be a task triggered by the Editor plugin which generates the jre when a new kotlin script is created (similar to the C# plugin) or when run is pressed but no jre is present (for the case when scripts are solely created outside the editor with Intellij for example). Also some good error messages would be nice (for example no JAVA_HOME found, JAVA <= 9 installed, and so on...).

Another possibility could be to handle this with a gradle task which get's called by the editor plugin.

Best might be to have both and execute the gradle task upon build and it checks on each build if a jre is present. So we cover the case where the godot editor is never started.

@piiertho
Copy link
Member

I agree we should make it as a gradle task, this would be easier for packaging games from CI

@raniejade
Copy link
Contributor

Can we also create a task for exporting the game? (downloading the templates automatically, etc ...) This will make supporting github actions easier.

@chippmann
Copy link
Contributor Author

Indeed but i propose we create a separate issue for that as for that we'd need to implement some rest calls and the accompanying logic which blows the scope of this issue up IMO. There are already quite a few changes in my branch for this.

@chippmann chippmann linked a pull request Nov 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants