Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Support for Windows platform #2960

Open
2 tasks
livk-cloud opened this issue Jan 16, 2025 · 9 comments
Open
2 tasks

client: Support for Windows platform #2960

livk-cloud opened this issue Jan 16, 2025 · 9 comments
Labels
Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. Feature Additional feature, big or small User issue Issue openned by users Users Pain An issue known to cause users pain, generaly open by the user.
Milestone

Comments

@livk-cloud
Copy link

livk-cloud commented Jan 16, 2025

Describe the feature

we need support for Windows platform

Use Case

some developers use Windows for development

Proposed Solution

glide.ffi.resolvers.NativeUtils#loadGlideLib add glideLib + ".dll"

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

Client version used

1.2.1

Environment details (OS name and version, etc.)

windows

@avifenesh
Copy link
Collaborator

avifenesh commented Jan 16, 2025

Hi @livk-cloud :) Thanks for opening the issue.
Can you please share which language you are using? Java?

@avifenesh avifenesh added Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. Users Pain An issue known to cause users pain, generaly open by the user. User issue Issue openned by users Feature Additional feature, big or small labels Jan 16, 2025
@livk-cloud
Copy link
Author

livk-cloud commented Jan 16, 2025

Hi @livk-cloud :) Thanks for opening the issue. Can you please share which language you are using? Java?

@avifenesh Thank you for your reply. I'm using Java and I'm thinking of using Valkey instead of redis and using the spring framework to integrate with valkey-glide. But the Windows platform is not supported at the moment, which annoys me. Hopefully sooner support for the Windows platform will be rolled out

@asafpamzn
Copy link
Collaborator

@yipin-chen , can you please evaluate the effort of windows support lets see when we can add it

@yipin-chen
Copy link
Collaborator

@yipin-chen , can you please evaluate the effort of windows support lets see when we can add it

Sure, we will look into it.

@Yury-Fridlyand
Copy link
Collaborator

At the moment, java (and python and node) clients cannot support windows, because these clients use unix-specific feature (UDS). Go and C# clients have another design without UDS and can support windows.
As an alternative option I can propose using WSL to run GLIDE on windows. Me and @jamesx-improving use windows PC to develop the clients, it works well.

@asafpamzn
Copy link
Collaborator

@livk-cloud will WSL support works for you.
@avifenesh please check with the rust team (Ariel) on Sunday. Maybe rust added support to UDS in windows and we can provide a solution for windows users.

@avifenesh
Copy link
Collaborator

@asafpamzn Will do!
@livk-cloud Please share if WSL is fine as a temporary solution, so we know if it's a blocker and we can prioritize.

@livk-cloud
Copy link
Author

livk-cloud commented Jan 18, 2025

@asafpamzn @avifenesh WSL is indeed a temporary solution, I need to use IDEA to connect to the local one 
WSL。 But if you consider teamwork, I can't force everyone to use WSL. Although Windows is not currently supported, I feel that we need to add support to Windows, just like jedis and lettuce, for multi-platform

@Yury-Fridlyand
Copy link
Collaborator

It's time for java FFI client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. Feature Additional feature, big or small User issue Issue openned by users Users Pain An issue known to cause users pain, generaly open by the user.
Projects
Status: No status
Development

No branches or pull requests

5 participants