Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-failure] valkey-cli shard pubsub test #1531

Closed
hpatro opened this issue Jan 8, 2025 · 3 comments · Fixed by #1533
Closed

[test-failure] valkey-cli shard pubsub test #1531

hpatro opened this issue Jan 8, 2025 · 3 comments · Fixed by #1533
Labels
test-failure An issue indicating a test failure

Comments

@hpatro
Copy link
Collaborator

hpatro commented Jan 8, 2025

https://github.com/valkey-io/valkey/actions/runs/12678118866/job/35335006630

*** [err]: valkey-cli pubsub mode with multiple shard channel subscriptions in tests/integration/valkey-cli.tcl
Expected '1' to be equal to '0' (context: type eval line 14 cmd {assert_equal "1" $pubsub_status} proc ::test)
Cleanup: may take some time... OK
@zuiderkwast
Copy link
Contributor

zuiderkwast commented Jan 8, 2025 •
edited
Loading

Introduced in #1432. 😢

@zuiderkwast zuiderkwast added the test-failure An issue indicating a test failure label Jan 8, 2025
@zuiderkwast
Copy link
Contributor 

SSUBSCRIBE schannel1 schannel2 schannel3

Is this a CROSSSLOT error in cluster mode? That would explain it. We can fix it by adding a {tag}?

SSUBSCRIBE {schannel}1 {schannel}2 {schannel}3

@enjoy-binbin
Copy link
Member

Is this a CROSSSLOT error in cluster mode? That would explain it. We can fix it by adding a {tag}?

yes, it is, i confirmed it locally

enjoy-binbin added a commit to enjoy-binbin/valkey that referenced this issue Jan 9, 2025
@enjoy-binbin
Fix new cli subscribed mode test in cluster mode
5211041 
We need to add a hash tag in cluster mode.
Fixes valkey-io#1531.

Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin mentioned this issue Jan 9, 2025
Merged
proost pushed a commit to proost/valkey that referenced this issue Jan 17, 2025
@enjoy-binbin @proost
Fix new cli subscribed mode test in cluster mode (valkey-io#1533)
ad9601d 
We need to add a hash tag in cluster mode.
Fixes valkey-io#1531.

Signed-off-by: Binbin <[email protected]>
Signed-off-by: proost <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test-failure An issue indicating a test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix new cli subscribed mode test in cluster mode enjoy-binbin/valkey
3 participants
@zuiderkwast @enjoy-binbin @hpatro