Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test failure] LATENCY of expire events are correctly collected (unit/latency-monitor) #1580

Open
zuiderkwast opened this issue Jan 17, 2025 · 2 comments · May be fixed by #1584
Open

[Test failure] LATENCY of expire events are correctly collected (unit/latency-monitor) #1580

zuiderkwast opened this issue Jan 17, 2025 · 2 comments · May be fixed by #1584
Assignees
@zuiderkwast
Labels
test-failure An issue indicating a test failure

Comments

@zuiderkwast
Copy link
Contributor

This test fails for me locally.

*** [err]: LATENCY of expire events are correctly collected in tests/unit/latency-monitor.tcl
Expected '{command 1737141346 674 674}' to match '*expire-cycle*' (context: type eval line 19 cmd {assert_match {*expire-cycle*} [r latency latest]} proc ::test)

I'm running Linux on Macbook M2.
@zuiderkwast zuiderkwast added the test-failure An issue indicating a test failure label Jan 17, 2025
@zuiderkwast
Copy link
Contributor Author

(Note to self.) I used git bisect and found that it started to fail at commit 88942c8, PR #1176.

@zuiderkwast
Copy link
Contributor Author

The reason it fails is that the hash table is just too fast. 😎

The expire cycle took only 15 milliseconds for deleting an expired set with a million elements. The threshold in the test case is set to 20. Lowering the threshold fixes the test case. I'll submit a PR soon.

@zuiderkwast zuiderkwast self-assigned this Jan 17, 2025
@zuiderkwast zuiderkwast linked a pull request Jan 18, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuiderkwast zuiderkwast

Labels
test-failure An issue indicating a test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lower latenct-monitor-threashold in expire-cycle test case zuiderkwast/placeholderkv
1 participant
@zuiderkwast