Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function routing #1

Open
lewisdaly opened this issue May 4, 2019 · 0 comments
Open

Fix function routing #1

lewisdaly opened this issue May 4, 2019 · 0 comments

Comments

@lewisdaly
Copy link
Contributor

There are a number of issues with routing:

  • need to specify a trailing slash / for number (eg. https://dfstalk.vessels.tech/number/)
  • the firebase hosting rerouting doesn't strip fields, meaning that /api/v1/number/ gets passed to the express router, which can't find the route. Perhaps this is something middleware can fix for us.
  • related to this is now we need to specify /number/number/languages when using the us-central1-dfs-talk.cloudfunctions.net/ host, but /number/languages when using the dfstalk.vessels.tech host
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant