Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Packet size mismatch! error on collection drop #2813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Packet size mismatch! error on collection drop #2813

wants to merge 1 commit into from

Conversation

gedaiu
Copy link
Contributor

@gedaiu gedaiu commented Jan 11, 2025

fix #2812

@gedaiu
Copy link
Contributor Author

gedaiu commented Jan 16, 2025

@WebFreak001 @s-ludwig any thoughts on this pr?

@s-ludwig
Copy link
Member

The change looks good, but the code in the unittest needs to be moved to a test in "/tests/mongodb", as the regular CI runs do not have a MongoDB server available. It can probably just be moved to "/tests/mongodb/_connection/source/app.d"

@WebFreak001
Copy link
Contributor

sounds good but please don't put it in the fundamental _connection test, but rather in some (perhaps new) collection management test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebFreak001 WebFreak001 WebFreak001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Packet size mismatch!" on dropping mongodb collection
3 participants
@gedaiu @s-ludwig @WebFreak001