Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Time Divider class #8953

Open
rtritto opened this issue Jan 6, 2025 · 0 comments
Open

Missing Time Divider class #8953

rtritto opened this issue Jan 6, 2025 · 0 comments
Labels
needs: triage This issue needs to be reviewed

Comments

@rtritto
Copy link

rtritto commented Jan 6, 2025

Description

The span of Time Display and the span of Duration Display have the related class (vjs-current-time-display and vjs-duration-display).
The span of Time Divider has not a class.

Current

<div class="vjs-time-control vjs-time-divider" aria-hidden="true">
  <div>
    <span>/</span>
  </div>
</div>

Expected

Maybe move vjs-time-divider class from div to span:

<div class="vjs-time-control" aria-hidden="true">
  <div>
    <span class="vjs-time-divider">/</span>
  </div>
</div>

Or add a new class to span:

<div class="vjs-time-control vjs-time-divider" aria-hidden="true">
  <div>
    <span class="vjs-time-divider-class">/</span>
  </div>
</div>

Use case

Increase the font size of related span value:

  • vjs-current-time-display
  • time divider
  • vjs-duration-display

Eg:

.vjs-current-time-display {
  font-size: 10px;
}
.vjs-time-divider {
  font-size: 11px;
}
.vjs-duration-display  {
  font-size: 12px;
}

Workaround

Use vjs-time-control instead but all 3 have same font size.
Eg:

.vjs-time-control {
  font-size: 14px;
}

Errors

No response

What version of Video.js are you using?

8.21.1

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Firefox

What OS(es) and version(s) does this occur with?

Windows

@rtritto rtritto added the needs: triage This issue needs to be reviewed label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

1 participant